On Wed, Apr 15, 2009 at 10:51 PM, Guy Albertelli <[email protected]> wrote: > On Wed, 2009-04-15 at 10:58 -0500, Austin English wrote: >> On Tue, Apr 14, 2009 at 11:17 PM, Guy Albertelli <[email protected]> wrote: >> > MSDN and test verify the valid "root dirs" for GetVolumeInformation[AW] >> > must end in trailing '\' and if not then return ERROR_INVALID_NAME >> > >> > Changelog >> > - Return correct error if GetVolumeInformation[AW] "root dir" does not >> > end with '\' >> > --- >> > dlls/kernel32/volume.c | 2 +- >> > 1 files changed, 1 insertions(+), 1 deletions(-) >> > >> > >> > >> > >> > >> >> Can you add a testcase for this? > > The test cases are in [1/3]. > > Thanks, Guy > >
You need to add todo_wine for the failing test you added: volume.c:290: Test failed: GetVolumeInformationA w/o '\' did not fail, last error 2 make: *** [volume.ok] Error 1 Then remove that todo in patch 2/3. Path 3/3 doesn't seem to affected, e.g., there's not a testcase for it, or the test is unaffected. -- -Austin
