On Do, 2009-06-11 at 15:04 -0700, James Hawkins wrote: > 2009/6/11 Vladimir Pankratov <[email protected]>: > > Hello all. > > > > Implemented ExtractFilesW > > > > Changed files: > > advpack/files.c
> You're converting A -> W -> A. > This happens because cabinet.Extract is (as far as we know) ansi-only. > In this case, I think it's ok to make ExtractFilesW call into > ExtractFilesA, with an appropriate comment as to why this is > happening. The crosscall should be avoided, when possible. As example, move the implementation to extract_filesAW(..., BOOL is_unicode) and made the API entry points a wrapper around this. -- By by ... Detlef
