> Anyway Alexandre is on holiday next week, so you'll have to > wait a bit to get his comments.
Yea, that's what I was afraid of. As far as the chunks, most of them do stand on their own with updated test code (one of them fails tests). I was considering submitting the patches in both the incremental form in addition to a single bulk patch. I guess it doesn't matter too much since you can do that pretty easily in git anyway. Thank you for the responses. Daniel --- On Sat, 7/25/09, Frédéric Delanoy <[email protected]> wrote: > From: Frédéric Delanoy <[email protected]> > Subject: Re: Request for Review: Cursor & Icon patches > To: "Roderick Colenbrander" <[email protected]> > Cc: "wine-devel" <[email protected]>, "lats" <[email protected]> > Date: Saturday, July 25, 2009, 9:56 AM > On 07/25/2009 02:06 PM, Roderick > Colenbrander wrote: > > On Sat, Jul 25, 2009 at 8:04 AM, lats<[email protected]> > wrote: > >> On 25/07/09 12:46, Daniel Santos wrote: > >> > >>> I finished the actual code about 3 weeks ago, > >>>> but it's been a lot of work for me to > split it out into > >>>> smaller pieces, especially being new to > git. > >> The intention is that is that you build and test > smaller chunks, hence the > >> term "commit often". It certainly makes it > easier later on. > >> > > > > Sure in general you should submit small chunks but in > this case it is > > a very invasive change and I think Alexandre wants to > see the overal > > work before he lets in small chunks (e.g. changes in > winex11, > > wineserver and other parts are needed). Unfortunately > I don't know > > anything about the cursor code, so can't comment on > it. I think Henri, > > Alexandre and perhaps some other can comment on it. > > > > Roderick > > Anyway Alexandre is on holiday next week, so you'll have to > wait a > bit to get his comments. > > > >
