On 09/11/2009 12:47 AM, Markus Stockhausen wrote:
Am Freitag, den 11.09.2009, 01:56 +0400 schrieb Nikolay Sivov:
Just correct your patch (as you mentioned before), include simple
testcase and resend.
So nothing to wait for.
Basic test shows it doesn't crash on Windows and doesn't change last
error - I already
check this on XP and it passes.
Ok, attached you will find my second try. Testcase of Nicolay included
this time. Hopefully it will be better this time.
Best regards.
------------------------------------------------------------------------
Hi Markus,
One I see is a style issue with the if statement. There shouldn't be a
space after the opening and before the closing bracket.
Another thing (style again) is that maybe it's nicer to return FALSE
instead of ret (as is done throughout this file).
--
Cheers,
Paul.
