Re: ws2_32: Use the routing table information for gethostbyname('self') if the magic IP would otherwise be returned.

[Kai Blin]

On Saturday 10 October 2009 22:52:48 Vitaliy Margolen wrote:

> > Changelog:
> >     ws2_32: Use the routing table information for
> > gethostbyname('self') if the magic IP would otherwise be returned.
> 
> Thanks for the patch, however there are few issues with it.
> 
> Why do you return a list of IP addresses from WS2_get_local_ips if you need
> only one? Just get the one with the lowest metric and return it.
> 
> I think it would be better

That's not what Windows does, though. Windows returns the full list.

Just my 2 cents,
Kai

-- 
Kai Blin
WorldForge developer  http://www.worldforge.org/
Wine developer        http://wiki.winehq.org/KaiBlin
Samba team member     http://www.samba.org/samba/team/
--
Will code for cotton.

signature.asc
Description: This is a digitally signed message part.