Owen Rudge wrote:
This patch adds support for scrolling a listview when performing a
marquee selection. In Windows, a listview will scroll around when
dragging and highlighting icons, picking up speed as you move the
mouse further past the window.
Hi, Owen.
This patch is rather large, so few comments:
+ RECT marqueeRect; /* absolute coordinates of marquee selection */
+ RECT marqueeDrawRect; /* relative coordinates for drawing marquee */
+ POINT marqueeOrigin; /* absolute coordinates of marquee click origin */
I don't think you need such duplication. Why not to use a single
rectangle? Looks like you always offset it to listview origin,
so these rectangle differ in offset only, that's why you introduced
another iterator_* helper. If I'm right about that it's better to
add another OffsetRect than consistently maintain two variables with
same meaning.
