Re: [PATCH 2/5] ddraw/tests: Check some more return values (LLVM/Clang).

[Paul Vriens]

On 10/16/2009 10:38 AM, Henri Verbeet wrote:
diff --git a/dlls/ddraw/tests/d3d.c b/dlls/ddraw/tests/d3d.c
index d9b1c72..9104147 100644
--- a/dlls/ddraw/tests/d3d.c
+++ b/dlls/ddraw/tests/d3d.c
@@ -961,6 +961,7 @@ static BOOL D3D1_createObjects(void)
      ddsd.dwWidth = 256;
      ddsd.dwHeight = 256;
      hr = IDirectDraw_CreateSurface(DirectDraw1,&ddsd,&Surface1, NULL);
+    ok(SUCCEEDED(hr), "IDirectDraw_CreateSurface returned %#x.\n", hr);
      if (!Surface1) {
          skip("DDSCAPS_3DDEVICE surface not available\n");
          return FALSE;

Hi Henri,

This one currently fails on some Win9x/WinMe boxes (VMware only)? As 
there is a skip() afterwards it seems like the call doesn't always need 
to be succeeding?

Should I just get rid of the ok() message and the assignment to hr? Or 
move the ok() till after the if()?

--
Cheers,

Paul.