Am 27.10.2009 05:14, schrieb Dan Kegel:
(Spotted by 
http://kegel.com/wine/valgrind/logs/2009-10-26-08.26/diff-d3d10_effect.txt
)

Hi Rico,
the patch

commit b55641f14a210f689cde8b08750a78779657c06e
Author: Rico Schüller<[email protected]>
Date:   Sun Oct 25 17:11:49 2009 +0100

     d3d10: Parse local_variables.

seems to have introduced the following valgrind error:

http://kegel.com/wine/valgrind/logs/2009-10-26-08.26/vg-d3d10_effect.txt

  Invalid free() / delete / delete[]
     at  notify_free (heap.c:222)
     by  RtlFreeHeap (heap.c:1474)
     by  d3d10_effect_Release (effect.c:1649)
     by  test_effect_constant_buffer_type (effect.c:193)
     by  func_effect (effect.c:1128)
     by  run_test (test.h:535)
     by  main (test.h:585)
   Address 0x7f03def0 is 104 bytes inside a block of size 112 alloc'd
     at  notify_alloc (heap.c:214)
     by  RtlAllocateHeap (heap.c:1421)
     by  D3D10CreateEffectFromMemory (d3d10_main.c:218)
     by  test_effect_constant_buffer_type (effect.c:93)
     by  func_effect (effect.c:1128)
     by  run_test (test.h:535)
     by  main (test.h:585)

and a number of small leaks of the form

  0 bytes in 1 blocks are definitely lost
     at  notify_alloc (heap.c:214)
     by  RtlAllocateHeap (heap.c:1421)
     by  parse_fx10_body (effect.c:1280)
     by  parse_fx10 (effect.c:1394)
     by  fx10_chunk_handler (effect.c:1408)
     by  parse_dxbc (effect.c:157)
     by  d3d10_effect_parse (effect.c:1418)
     by  D3D10CreateEffectFromMemory (d3d10_main.c:230)
     by  test_effect_variable_element (effect.c:665)
     by  func_effect (effect.c:1131)
     by  run_test (test.h:535)
     by  main (test.h:585)

Could you have a look?

Thanks,
Dan

Hi Dan,

the HeapFree() call is wrong in this patch, I'll send a fix for that. Thanks for the hint.

Cheers
Rico


Reply via email to