On 01/03/2010 10:12 PM, Gerald Pfeifer wrote:
On Sun, 3 Jan 2010, Austin English wrote:
On my FreeBSD test system I am see no warnings triggered by -Wlogical-op
any more. How does it look on your side?
ole32:
usrmarshal.c:485: warning: logical ?&&? with non-zero constant will
always evaluate as true
usrmarshal.c:1098: warning: logical ?&&? with non-zero constant will
always evaluate as true
usrmarshal.c:1290: warning: logical ?&&? with non-zero constant will
always evaluate as true
oleaut32:
variant.c:2090: warning: logical ?||? with non-zero constant will
always evaluate as true
variant.c:2090: warning: logical ?&&? with non-zero constant will
always evaluate as true
comctl32/tests:
tab.c:520: warning: logical ?&&? with non-zero constant will always
evaluate as true
tab.c:540: warning: logical ?&&? with non-zero constant will always
evaluate as true
tab.c:563: warning: logical ?&&? with non-zero constant will always
evaluate as true
tab.c:978: warning: logical ?&&? with non-zero constant will always
evaluate as true
I had a patch for this one (comctl32/tests) which I received feedback on
and need to brush up. I should be able to do so coming week. Anybody
volunteering to look into the other ones?
kernel32/tests:
atom.c:70: warning: logical ?||? with non-zero constant will always
evaluate as true
Gerald
The attached is what I have on my F12 box (gcc 4.4.2 20091222):
--
Cheers,
Paul.
make[2]: Entering directory '/wine/wine-git/tools/winebuild'
parser.c:82: warning: logical '&&' with non-zero constant will always evaluate
as true
parser.c:87: warning: logical '&&' with non-zero constant will always evaluate
as true
make[2]: Entering directory '/wine/wine-git/dlls/msvcrt'
mbcs.c:109: warning: logical '&&' with non-zero constant will always evaluate
as true
string.c:102: warning: logical '&&' with non-zero constant will always evaluate
as true
string.c:105: warning: logical '&&' with non-zero constant will always evaluate
as true
wcs.c:398: warning: logical '&&' with non-zero constant will always evaluate as
true
wcs.c:406: warning: logical '&&' with non-zero constant will always evaluate as
true
wcs.c:414: warning: logical '&&' with non-zero constant will always evaluate as
true
make[2]: Entering directory '/wine/wine-git/dlls/ntdll'
path.c:886: warning: logical '&&' with non-zero constant will always evaluate
as true
printf.c:247: warning: logical '&&' with non-zero constant will always evaluate
as true
printf.c:255: warning: logical '&&' with non-zero constant will always evaluate
as true
printf.c:263: warning: logical '&&' with non-zero constant will always evaluate
as true
string.c:130: warning: logical '&&' with non-zero constant will always evaluate
as true
make[2]: Entering directory '/wine/wine-git/dlls/ole32'
usrmarshal.c:485: warning: logical '&&' with non-zero constant will always
evaluate as true
usrmarshal.c:1098: warning: logical '&&' with non-zero constant will always
evaluate as true
usrmarshal.c:1290: warning: logical '&&' with non-zero constant will always
evaluate as true
make[2]: Entering directory '/wine/wine-git/dlls/oleaut32'
variant.c:2090: warning: logical '||' with non-zero constant will always
evaluate as true
variant.c:2090: warning: logical '&&' with non-zero constant will always
evaluate as true
make[2]: Entering directory '/wine/wine-git/dlls/riched20'
editor.c:3256: warning: logical '&&' with non-zero constant will always
evaluate as true
editor.c:3256: warning: logical '&&' with non-zero constant will always
evaluate as true
editor.c:3256: warning: logical '&&' with non-zero constant will always
evaluate as true
editor.c:3257: warning: logical '&&' with non-zero constant will always
evaluate as true
editor.c:3257: warning: logical '&&' with non-zero constant will always
evaluate as true
editor.c:3257: warning: logical '&&' with non-zero constant will always
evaluate as true
editor.c:3535: warning: logical '&&' with non-zero constant will always
evaluate as true
editor.c:3535: warning: logical '&&' with non-zero constant will always
evaluate as true
editor.c:3535: warning: logical '&&' with non-zero constant will always
evaluate as true
editor.c:3536: warning: logical '&&' with non-zero constant will always
evaluate as true
editor.c:3536: warning: logical '&&' with non-zero constant will always
evaluate as true
editor.c:3536: warning: logical '&&' with non-zero constant will always
evaluate as true
make[2]: Entering directory '/wine/wine-git/dlls/shell32'
shv_bg_cmenu.c:418: warning: logical '&&' with non-zero constant will always
evaluate as true
shv_bg_cmenu.c:418: warning: logical '&&' with non-zero constant will always
evaluate as true
shv_bg_cmenu.c:418: warning: logical '&&' with non-zero constant will always
evaluate as true
shv_bg_cmenu.c:419: warning: logical '&&' with non-zero constant will always
evaluate as true
shv_bg_cmenu.c:419: warning: logical '&&' with non-zero constant will always
evaluate as true
shv_bg_cmenu.c:419: warning: logical '&&' with non-zero constant will always
evaluate as true
shv_bg_cmenu.c:420: warning: logical '&&' with non-zero constant will always
evaluate as true
shv_bg_cmenu.c:420: warning: logical '&&' with non-zero constant will always
evaluate as true
shv_bg_cmenu.c:420: warning: logical '&&' with non-zero constant will always
evaluate as true
xdg.c:403: warning: logical '&&' with non-zero constant will always evaluate as
true
make[2]: Entering directory '/wine/wine-git/dlls/comctl32/tests'
tab.c:520: warning: logical '&&' with non-zero constant will always evaluate as
true
tab.c:540: warning: logical '&&' with non-zero constant will always evaluate as
true
tab.c:563: warning: logical '&&' with non-zero constant will always evaluate as
true
tab.c:978: warning: logical '&&' with non-zero constant will always evaluate as
true
make[2]: Entering directory '/wine/wine-git/dlls/kernel32/tests'
atom.c:70: warning: logical '||' with non-zero constant will always evaluate as
true
locale.c:1912: warning: logical '&&' with non-zero constant will always
evaluate as true
locale.c:1934: warning: logical '&&' with non-zero constant will always
evaluate as true
locale.c:1967: warning: logical '&&' with non-zero constant will always
evaluate as true
