Le lundi 15 mars 2010 à 13:05 +0100, Alexandre Julliard a écrit : > Yann Droneaud <[email protected]> writes: > > >> Note: Quoting were not added for WINE macros related to Makefile generation > >> as they broke things: there are some quoting magic in aclocal.m4 not > >> fixed by this patch. > > > > As stated in the patch log, it can be applied safely. > > > > But once applied on current HEAD, most pending patches on configure.ac > > won't apply. > > Which is why the patch won't be applied. There's no need for such a > large scale cleanup. If some macros really have quoting issues you can > fix those and leave the rest alone. >
Yes, I can fix only those. But, the patch was targeting consistency: configure.ac script uses macros sometimes with proper quoting, sometimes not. There's no rule. This patch was trying to ensure that all macro calls were written the same way, so if someone was looking for some copy/paste to add new tests/new features, only sane default would be used. So I'm dropping this patch and will send multiple small fix to specific macro calls. Regards. -- Yann Droneaud
