Re: [PATCH 6/7] wined3d: Add an initial fbo_blit_supported implementation.

[Henri Verbeet]

On 8 April 2010 22:49, Roderick Colenbrander <thunderbir...@gmail.com> wrote:
> +    /* Source and/or destination need to be on the GL side */
> +    if (src_pool == WINED3DPOOL_SYSTEMMEM || dst_pool == 
> WINED3DPOOL_SYSTEMMEM)
> +        return FALSE;
...
> +    if (!is_identity_fixup(src_format_desc->color_fixup) ||
> +        !is_identity_fixup(dst_format_desc->color_fixup))
> +        return FALSE;
These weren't in the original function. Perhaps they should but, but
as separate patches, please.

> +    if (!(src_format_desc->format == dst_format_desc->format
> +        || (is_identity_fixup(src_format_desc->color_fixup)
> +        && is_identity_fixup(dst_format_desc->color_fixup))))
> +        return FALSE;
This entire check would be redundant after the is_identity_fixup() checks above.