On 04/24/2010 10:53 AM, Ilya Basin wrote:
1) removes the block of code that splits lpFile into filename and
parameters and removes '"'s from filename . Even without this block
ShellExecute not fails with quoted lpFile.
2) removes 2 corresponding todo_wine's from tests.
The real application affected by this bug is uTorrent: if you have 2
downloads containing, say,
"foo/bar.avi" and "foo 2/baz.avi", when you double click the latter
avi file, it'll open the explorer in folder "foo" instead.
try 2:
disabled todo_wine for "%s\\masked file.shlexec"
instead of disabling all todo_wine's in the loop
try 3:
try 2 didn't apply cleanly in git: ok() format string changed.
Hi Ilya,
In your last email on wine-devel about this subject you mentioned adding
some extra tests. There was at least some communication with you and the
author of that piece you are now removing. The reason for that piece was
shown in a code-snippet he gave and adding tests for that specific case
would be worthwhile I think.
--
Cheers,
Paul.
