On Sun, Aug 29, 2010 at 7:00 PM, James McKenzie <jjmckenzi...@earthlink.net> wrote: > One additional note: We should, as a project, not accept 'broken' code. I > work with a real-time project and get paid for this that soon will have this > policy in effect. No broken code, it is way to hard to go back and fix it > later. This is one thing I like AJ for. The DIB engine is his one > execption in that he wants it fully implemented and all in one piece. > > Also, Max's code has shown up in another 'for pay' project and where > implementation was done, works. Where implementation is not complete, it is > seriously broken. The problem is where it works and does not work is not > cleanly defined. Lots of 'surprises' and 'gotchas'. > > Anyway, Jeff, please look at Max's code and then ask AJ for specific > guidance on the how to work on this. This is a MAJOR part of the project > that needs to be implemented. Don't feel insulted when you get reject after > reject from AJ. As specific questions, and he does give answers. If he > states "it's broken" he wants you to figure it out and the brokenness is > very obvious. Yes, I've had patches rejected by him and that is all he > said. I figured out the brokenness and fixed it. I've had to back off the > patch as it used code that was rejected and now I know why.
James, I hate to be blunt, but you've been repeatedly told to stop giving advice while implying that you are a senior wine developer with lots of experience on the project. I've seen several (potential) new contributors take your advice, submit patches based on it, then have to rework a lot of it based on faulty advice. Lots of people on wine-devel aren't wine developers, or contribute infrequently, but still give good advice, based on what they know and their experience. However, giving authoritative answers when you lack that authority/experience is damaging not only to those contributors, but to wine as a whole. I think http://www.winehq.org/pipermail/wine-devel/2010-July/085495.html sums it up very nicely. /rant -- -Austin
