On 27 February 2011 20:22, Misha Koshelev <[email protected]> wrote:
> +static HRESULT WINAPI 
> ID3DXRenderToSurfaceImpl_QueryInterface(ID3DXRenderToSurface *iface, REFIID 
> riid, void **ppobj)
> +{
> +    ID3DXRenderToSurfaceImpl *This = impl_from_ID3DXRenderToSurface(iface);
You don't actually need "This" here.

> +        return D3D_OK;
S_OK is more appropriate for QueryInterface.

> +    WARN("(%p)->(%s,%p),not found\n", This, debugstr_guid(riid), ppobj);
> +    return E_NOINTERFACE;
> +}
You should set "*ppobj" to NULL here, unless there's a reason not to.


Reply via email to