The recent changes to the cursor and keyboard handling absolutely kill performance in Fallout: New Vegas. The cursor changes cause the mouse to jump around (when you move the mouse while using the keyboard) and the keyboard-specific changes cause the entire game to lock up temporarily about once a second when moving solely by keyboard. I believe I've narrowed down the problem with the keyboard changes (the issue is caused by commit bc4afb078677095468d4ee8f9a15c18cbb47bbbf, see attached proposed fix), but I did not have time this evening to explore the root cause of the cursor problem. Since I'm not certain why this particular line in the commit was changed in the first place, I figured I'd bring it up here, in case I'm missing something, before sending the attached to wine-patches.
Erich Hoover [email protected]
From 1c222c2cbc4963abd468d26ae6f5010c99578142 Mon Sep 17 00:00:00 2001 From: Erich Hoover <[email protected]> Date: Tue, 1 Mar 2011 22:52:49 -0700 Subject: server: Fix Fallout New Vegas when send_hardware_message is called with a NULL message. --- server/queue.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/queue.c b/server/queue.c index 58be426..6cdb3d7 100644 --- a/server/queue.c +++ b/server/queue.c @@ -1747,7 +1747,7 @@ DECL_HANDLER(send_hardware_message) } else if (!(desktop = get_thread_desktop( current, 0 ))) return; - if (!(data = mem_alloc( sizeof(*data) ))) goto done; + if (!req->msg || !(data = mem_alloc( sizeof(*data) ))) goto done; memset( data, 0, sizeof(*data) ); data->x = req->x; -- 1.7.1
