On 3/3/11 2:45 PM, Alexandre Julliard wrote:
Jacek Caban<[email protected]>  writes:

+    /* FIXME: Implement in more generic and safe way */
+    for(ptr = name; *ptr&&  isdigitW(*ptr); ptr++)
+        i = i*10 + (*ptr-'0');
What's wrong with strtoulW?

We don't want to use strings like "+1" or with leasing spaces for indexed access. The comment was more about considering moving it to IDispatchEx implementation layer than parsing itself. BTW, it's a really broken design of IDispatchEx. When a scripts accesses property by integer index, the integer is converted to string and passed to GetDispID, which parses it back.

Thanks,
    Jacek


Reply via email to