The patch is not mine. I've adapted it to work on wine 1.3.15. The purpose of this patch is give a system cursor in WoW 3.3.5
2011/3/13 Vitaliy Margolen <[email protected]> > On 03/13/2011 02:31 PM, Valentino Dell'Aica wrote: > >> Hi I've modified a patch for hw cursor in wine so it can work on wine >> 1.3.15 >> > You have number of problems with your patch formatting with are outlined > here: http://wiki.wi <http://wiki.winehq.org/SubmittingPatches> > > nehq.org/SubmittingPatches <http://wiki.winehq.org/SubmittingPatches> > > + hwgl = getenv("WINE_CURSOR"); >> > Wine uses registry for things like this. It should be a static variable set > once. > > + WINE_FIXME("Out of memory.\n"); >> > For wine libraries this should be "FIXME". Also just printing fixme isn't a > good error handling. > > And can you explain why for every button press/release you > creating/removing cursor? This is highly inefficient. And what are you > trying to archive with it anyway? > > Vitaliy. > -- Valentino Dell'Aica _______________________________________ Via Bella Venezia 3, 31043 Fontanelle (TV) _______________________________________ There are three schools of magic. One: State a tautology, then ring the changes on its corollaries; that's philosophy. Two: Record many facts. Try to find a pattern. Then make a wrong guess at the next fact; that's science. Three: Be aware that you live in a malevolent Universe controlled by Murphy's Law, sometimes offset by Brewster's Factor; that's engineering.
