On Mon, 2011-04-18 at 10:36 +0200, Marcus Meissner wrote: > On Mon, Apr 18, 2011 at 10:04:08AM +0200, Hans Leidekker wrote: > > On Sun, 2011-04-17 at 09:42 -0400, [email protected] wrote: > > > #ifdef SONAME_LIBGNUTLS > > > #include <gnutls/gnutls.h> > > > +#include <gcrypt.h> > > > +#include <pthread.h> > > > +#include <errno.h> > > > +GCRY_THREAD_OPTION_PTHREAD_IMPL; > > > > You should add a separate configure check for libgcrypt. Use of pthreads > > reveals an implementation detail of Wine threads, I think it would be > > cleaner to supply Win32 implementations of the locking functions via > > GCRY_THREAD_OPTION_USER. > > I also wonder why libgcrypt is now needed, where this dll is using libgnutls?
Yes, if there's a way to set the locking functions via gnutls then we wouldn't need to load libgcrypt.
