On 08/25/11 14:09, Octavian Voicu wrote:
On Thu, Aug 25, 2011 at 2:59 PM, Jacek Caban<[email protected]> wrote:
Those are failures on Wine, so tests are fine, it's Wine that needs fixing.
Yes, the first test usually fails on Wine. Nonetheless, if
CoCreateInstance fails for whatever reason (like it happens on that
NT4 machine, for example), running the rest of the tests is pointless
and will definitely crash.
It's annoying to get crashes while running tests. The skip is not
really needed I guess, but the return should be there to stop the
crashing.
As long as there is a failure (like in your patch), I'm fine with
return. Just let's not pretend it's somehow valid run with skip() call.
Also testing hres is cleaner than unk, IMO.
Jacek
