Francois Gouget <[email protected]> writes: > I'm actually not entirely happy with this patch. > > Wine actually hardcodes the fallback fonts to Liberation Serif and > Tahoma. So we could instead check that if on Wine and the Windows fonts > are not installed then we get the fallback fonts. > > It's a bit what the test was trying to do with Microsoft Sans Serif > except that I also take exception with the todo_wine since the fix is > not to change Wine but to install the missing font.
I don't think the name of the family really matters here. By using Tahoma the Wine implementation is trying to make sure we always return something, and that's what we should check: that we get a family, and that it's valid for creating a font or something along those lines. -- Alexandre Julliard [email protected]
