2012/5/10 Juan Lang <[email protected]>:
> Hi Alex,
> first, thanks for taking the time to respond to feedback.  Showing
> responsiveness helps a great deal.

You're welcome :-)

> These helpers don't really gain you anything here, there's really not
> enough code to be worth using helpers.  Please just copy/paste the
> changes everyplace you're currently using them.  Also, a common
> convention we use is to set last error to 0xdeadbeef prior to a test
> we expect to set last error on failure.

Good idea. Try 5 looks a lot nicer. Thanks for the feedback!

-Alex


Reply via email to