Hi Austin, On 05/14/12 08:19, Austin English wrote: > clang -c -I. -I. -I../../../include -I../../../include > -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT > -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement > -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits > -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith > -I/usr/include/freetype2 -g -O0 -std=gnu89 -o http.o http.c > http.c:212:52: warning: use of logical '||' with constant operand > [-Wconstant-logical-operand] > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_NUMBER, &code, &size, &index); > ^ ~~~~~~~~~~~~~~~~~~~~~~ > http.c:212:52: note: use '|' for a bitwise operation > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_NUMBER, &code, &size, &index); > ^~~~~~~~~~~~~~~~~~~~~~~~ > | > http.c:218:52: warning: use of logical '||' with constant operand > [-Wconstant-logical-operand] > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_REQUEST_HEADERS, &code, &size, > NULL); > ^ > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > http.c:218:52: note: use '|' for a bitwise operation > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_REQUEST_HEADERS, &code, &size, > NULL); > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >
Thanks for the patch. The problem found by those warnings was more serious as we were tested a wrong thing, causing the implementation to be wrong. That said, we need to fix tests and implementation as well. I've sent a patch. Thanks, Jacek
