Thanks for the feedback! I'll clean up and re-submit.
(Now I'll have to decide whether to change my comment style for
everything I write, or just try to remember to fix them for winehq
patches ... ;) )
On 9/11/12 11:58 AM, Austin English wrote:
On Tue, Sep 11, 2012 at 9:32 AM, Josh DuBois <[email protected]> wrote:
Presence of a stub of msls31.dll allows Visio 2003 to open .svg files, which
it fails to do without the stub.
Visio 2003 does complain that some values in the files are missing or of the
incorrect data type when opening these files, but it will nonetheless open
them and can edit them successfully when the stubbed .dll is present.
@@ -0,0 +1,79 @@
+70 stub LssbFDoneDisplay
+65 stub LsCompressSubline
+1 stub LsCreateContext
+3 stub LsCreateLine
..etc.
Does it really need them by ordinal? The spec files are typically
sorted alphabetically by function name, e.g.,:
+@ stub LsCompressSubline
+@ stub LsCreateContext
+@ stub LsCreateLine
+@ stub LssbFDoneDisplay
..etc.
Some other minor things:
A) you don't need to include the changes to configure, just configure.ac.
B) Your comments are formatted a bit strange
/* ---------------------------------------------------------------
** msls31.dll
** Copyright CodeWeavers, Inc.
** Created: 9/10/2012 by Josh DuBois for CodeWeavers.
most files have:
/*
* msls31.dll
*
* Copyright 2012 Josh DuBois for CodeWeavers, Inc.
*
*/
similar for your comment about preferring the native version.
Welcome to Wine!
