On 19.10.2012 13:15, Nozomi Kodama wrote:
This patch adds tests for the patch sent by Rico for D3DXSHRotateZ.
Moreover, I changed const in CONST in the declaration of the function in
order to uniformize with the file.
> + const FLOAT angle[] = ...
I'd prefer "const" because it is used a little bit more often than
CONST, but it is only a matter of taste.
git grep "[ (,]const " | wc -l
~61k
git grep "[ (,]CONST " | wc -l
~1.2k
+ if ( i >= square || ( (order >= D3DXSH_MAXORDER) && ( i >=
D3DXSH_MAXORDER * D3DXSH_MAXORDER ) ) )
+ if (l > 0)
I'd write it "if (i >= square || ((... for consistency.
+ ok(relative_error(expected, out_temp[i]) < admitted_error,
"angle %f, order %u index %u, Expected %f, received %f\n", angle[j], order, i,
expected, out_temp[i]);
Expected -> expected? (2 times)
> + expected = table[36 * (l + 3 * j ) + i];
The spacing looks a bit ugly.
Cheers
Rico
