Hi Chris. Welcome to Wine.
> Main changes from HEAD: > 1) Implements GetNumaHighestNodeNumber which simulates a typical single node > system. > 2) Implements GetNumaNodeProcessorMask which returns the global processor > affinity mask for node 0, otherwise returns an error. > 3) Implements GetNumaAvailableMemoryNode which returns available physical > memory for node 0, otherwise returns an error. The hacks from the codeweavers Wine tree are not in the main tree, because they are hacks. Wine has either a stub or proper implementation with tests. For your changes: - SetLastError(0) is wrong. lasterror is only valid on a failure. (Exceptions are very very rare) - Most implementations in kernel32.dll use functions provides by ntdll.dll With grep, you will find numa support in dlls/ntdll/nt.c - Make the patches as small as possible: Only one implementation per Patch. - Please add tests and run them on Windows. Ask here, if you need help. (Wine has a testbot for approved developer) Thanks for improving Wine. -- By by ... Detlef
