Hello, this patch is in pending status, is there any way I can improve it?

IMO there is no way to 'correctly' implement OpenInputDesktop before
implementing SwitchDesktop, as far as SwitchDesktop is a stub, it is
safe to assume that OpenInputDesktop will always return either NULL or
Winsta0/Default, that is what the patch does and what the tests in
[PATCH 3/5] shows..

It is not trivial to implement SwitchDesktop, also I don't know any
real world app needing SwitchDesktop except some virtual desktop
manager, so I'm not sure it is worth to spend time on implementing
SwitchDesktop. However, OpenInputDesktop is needed by multiple apps
(TeamViewer, QQ International, Inspect tool from Windows Platform SDK
as bug 12067), is it acceptable to submit such a 'better stub' to Wine
and leaving SwitchDesktop as a stub?

Any comment is great appreciated!

On Tue, Oct 8, 2013 at 11:41 AM, Qian Hong <qh...@codeweavers.com> wrote:
> Fixed http://bugs.winehq.org/show_bug.cgi?id=12067 , let QQ users happy :)
> ---
>  dlls/user32/tests/winstation.c |   22 ----------------------
>  dlls/user32/winstation.c       |   22 +++++++++++++++++++---
>  2 files changed, 19 insertions(+), 25 deletions(-)

Qian Hong


Reply via email to