One quick note, I added an explicit part for logging messages. Basically I think we should externalize any logging message strings into a message.properties file that are not debug messages (for NLS and the like).
On Tue, Jun 9, 2009 at 9:26 AM, Bryant Luk<[email protected]> wrote: > I like the coding guidelines. I think using Maven would be good. The > only issue I think we need to address is making sure that we allow the > integration tests to run on various platforms.(jetty, tomcat, > geronimo, etc.), maybe via the Maven profiles functionality. > > On Mon, Jun 8, 2009 at 8:50 AM, Elman, Michael<[email protected]> wrote: >> I've created "Coding Guidelines" under the "Project Guidelines". >> Feel free to modify/add/discuss. >> >> Michael Elman >> >> >> -----Original Message----- >> From: Bryant Luk [mailto:[email protected]] >> Sent: Friday, June 05, 2009 6:10 AM >> To: [email protected] >> Subject: Re: Wink Project Guidelines >> >> >> I've updated the Wink Wiki with some of the project guidelines at: >> >> http://cwiki.apache.org/confluence/display/WINK/Project+Guidelines >> >> I copied what I thought was relevant for now. Feel free to >> modify/add/discuss. >> >> Thanks, >> >> Bryant Luk >> [email protected] >> >> >> Davanum Srinivas <[email protected]> wrote on 06/04/2009 08:25:09 PM: >> >>> [image removed] >>> >>> Re: Wink Project Guidelines >>> >>> Davanum Srinivas >>> >>> to: >>> >>> wink-dev >>> >>> 06/04/2009 08:26 PM >>> >>> Please respond to wink-dev >>> >>> Eli, Bryant, >>> >>> Feel free to use the wiki: >>> http://cwiki.apache.org/confluence/display/WINK/Index >>> >>> thanks, >>> dims >>> >>> On Thu, Jun 4, 2009 at 8:39 AM, Baram, Eliezer<[email protected]> wrote: >>> > Hi >>> > I think it can be a starting point, there are some modifications I >>> believe we should add, but in general it look good. >>> > let's copy it as a draft and then do the modifications and >>> discussions upon it. >>> > Regards, >>> > Eli >>> > >>> > >>> > >>> > >>> > -----Original Message----- >>> > From: Bryant Luk [mailto:[email protected]] >>> > Sent: Wednesday, June 03, 2009 11:39 PM >>> > To: [email protected] >>> > Subject: Wink Project Guidelines >>> > >>> > >>> > Hi all, >>> > >>> > For project guidelines, Jakarta seems to have a well written set >> (thanks >>> > Carlton): >>> > >>> > http://jakarta.apache.org/site/guidelines.html >>> > >>> > Any thoughts if we should just copy these guidelines for Wink? Some of >>> > these aren't applicable but these seem fairly standard in how other >> Apache >>> > projects are run. >>> > >>> > I imagine that more coding guidelines would need to be done later (like >>> > maybe formatting, logging, NLS, etc.) >>> > >>> > Thanks, >>> > >>> > Bryant Luk >>> > [email protected] >>> > >>> >>> >>> >>> -- >>> Davanum Srinivas :: http://davanum.wordpress.com >> > > > > -- > > - Bryant Luk > -- - Bryant Luk
