[
https://issues.apache.org/jira/browse/WINK-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727305#action_12727305
]
Jason Dillon commented on WINK-37:
----------------------------------
More specifically I don't recommend checking arguments for nulls and then
returning a null, as that moves the error checking down to the caller and IMO
not very nice... this is Java not C na ;-)
Assert comes in handy here as you can get an exception when they are enabled,
which I recommend doing for integration or unit testing, and don't incur any
performance cost when in a tests production environment.
> detection of null params to avoid NPE
> -------------------------------------
>
> Key: WINK-37
> URL: https://issues.apache.org/jira/browse/WINK-37
> Project: Wink
> Issue Type: Improvement
> Components: Common
> Affects Versions: 0.1
> Reporter: Mike Rheinheimer
> Attachments: npe_patch.txt
>
>
> I was working on a few bigger integration tests, and ran into some NPEs in
> ProvidersRegistry due to my resource passing null params into ProvidersImpl.*
> methods. Granted, this is something an app or resource should not normally
> do, but I think some protection against NPE would be good here. Please see
> proposed patch with tests.
> The supplied test is a start on building up more ProvidersImpl unittests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
