[
https://issues.apache.org/jira/browse/WINK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728026#action_12728026
]
Nadav Fischer commented on WINK-28:
-----------------------------------
At this point I'm not sure we still want to continue using the json files
internally.
Let's go with using the json library externally.
The patch looks good, though I personally don't really like the "assert input
!= null;" line in JSONUtils, I think throwing a NullPointerException is better,
but that's just me.
BTW, Here's some context for previous discussion that took place on the mailing
list:
{noformat}
AFAIK these json/* bits are the only ones.
--jason
On Jul 7, 2009, at 5:08 PM, Davanum Srinivas wrote:
> Yes, please identify all pieces of code that are clearly not covered
> by the software grants like this one. Once you have a list we can
> take the next step of identifying licenses and replacing
> questionable ones.
>
> thanks,
> dims
>
> On 07/07/2009 02:26 AM, Jason Dillon wrote:
>> Fair enough. I still think we need to resolve the license of them
>> wrt
>> Wink though, but IANAL :-(
>>
>> I recommend creating a wink-json module to hold onto these.
>>
>> --jason
>>
>>
>> On Jul 5, 2009, at 7:07 PM, Fischer, Nadav wrote:
>>
>>> Sorry for the late response, I was out of office until today...
>>>
>>> There were two reasons for not using json.org as a 3rd party
>>> dependency. First, we wanted to have as few as possible
>>> dependencies -
>>> it makes life easier for users. Second, the json library uses
>>> StringBuffer for all of its work, so to increase performance I
>>> changed
>>> all of the StringBuffer instances to StringBuilder.
>>>
>>> It's true that using the json sources as part of our sources has the
>>> disadvantage of not progressing with the natural development of the
>>> json library, but at that time, the two advantages I mentioned above
>>> were more important.
>>>
>>> So, do we stay with the modified json sources we have now or go with
>>> the json library as a separate dependency?
>>>
>>> -Nadav
>>>
>>> -----Original Message-----
>>> From: Jason Dillon [mailto:jason dillon gmail com] On Behalf Of
>>> Jason
>>> Dillon
>>> Sent: Wednesday, July 01, 2009 13:00
>>> To: wink-dev incubator apache org
>>> Subject: Re: Legal headers on org/apache/wink/common/model/json/
>>> *.java
>>>
>>> Is there any reason why we don't simply use the org.json:json:
>>> 20090211
>>> dependencies instead of including these sources?
>>>
>>> --jason
>>>
{noformat}
> Use published org.json dependencies instead of duplicating sources
> ------------------------------------------------------------------
>
> Key: WINK-28
> URL: https://issues.apache.org/jira/browse/WINK-28
> Project: Wink
> Issue Type: Improvement
> Components: Common, Server
> Reporter: Jason Dillon
> Assignee: Nadav Fischer
> Fix For: 0.1
>
> Attachments: WINK-28.patch
>
>
> The following sources do not have the standard ASL 2.0 legal header on them:
> * wink-common/src/main/java/org/apache/wink/common/model/json/JSONArray.java
> * wink-common/src/main/java/org/apache/wink/common/model/json/JSONObject.java
> *
> wink-common/src/main/java/org/apache/wink/common/model/json/JSONStringer.java
> *
> wink-common/src/main/java/org/apache/wink/common/model/json/JSONTokener.java
> * wink-common/src/main/java/org/apache/wink/common/model/json/JSONWriter.java
> instead they have:
> {noformat}
> /*
> Copyright (c) 2002 JSON.org
> Permission is hereby granted, free of charge, to any person obtaining a copy
> of this software and associated documentation files (the "Software"), to deal
> in the Software without restriction, including without limitation the rights
> to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> copies of the Software, and to permit persons to whom the Software is
> furnished to do so, subject to the following conditions:
> The above copyright notice and this permission notice shall be included in all
> copies or substantial portions of the Software.
> The Software shall be used for Good, not Evil.
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
> AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
> OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> SOFTWARE.
> */
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
