[
https://issues.apache.org/jira/browse/WINK-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryant Luk updated WINK-151:
----------------------------
Attachment: WINK-151-2.patch
Here's my slightly modified proposal.
I think since it is documented in the 0.1 release with all the PDF/word files
that we should maintain compatibility with the older class and keep the init*
methods for now. I do understand that we want to keep internal APIs private
but for migration purposes this doesn't cost us anything and we can have a
deprecation/warning.
I also believe this fixes a minor issue with the case where the boolean
VALIDATE_LOCATION_HEADER and the associated handler wasn't being checked if
there wasn't a handlerproviders class called. I also correct a slight typo in
the unit test. Dunno if that was intentional or not.
I'm even more terrible with names so I'll defer to Nick's suggestions...
> Make deployment configuration public
> ------------------------------------
>
> Key: WINK-151
> URL: https://issues.apache.org/jira/browse/WINK-151
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Michael Elman
> Fix For: 0.2
>
> Attachments: WINK-151-2.patch, WINK-151.patch
>
>
> Make DeploymentConfiguration or at least the documented methods into a public
> interface outside internal.
> The public interface should be implemented by DeploymentConfiguration if
> going with that option.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
