[
https://issues.apache.org/jira/browse/WINK-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753612#action_12753612
]
Michael Elman commented on WINK-175:
------------------------------------
AFAIK ConcurrentHashMap uses ReentrantLock and not ReentrantReadWriteLock.
Anyway, if you think that the tests are good and ConcurrentHashMap has better
performance over SimpleConcurrentMap, feel free to change it.
> Change ProvidersRegistry MediaTypeMap to allow gets to be faster
> ----------------------------------------------------------------
>
> Key: WINK-175
> URL: https://issues.apache.org/jira/browse/WINK-175
> Project: Wink
> Issue Type: Improvement
> Components: Common
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Fix For: 0.2
>
>
> Doug Larson did some more profiling and pointed out that on the
> ProvidersRegistry MediaTypeMap, using a ConcurrentHashMap over
> SimpleConcurrentMap actually improves performance by a few percentage points.
> {code}
> private final SimpleMap<Class<?>, SoftReference<SimpleMap<MediaType,
> List<ObjectFactory<T>>>>> providersCache =
>
> new SimpleConcurrentMap<Class<?>,
> SoftReference<SimpleMap<MediaType, List<ObjectFactory<T>>>>>(); ;
> {code}
> While the cache keys (Class<?>) would not be WeakReferences, the values would
> still be SoftReferences.
> Thoughts?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
