Change XmlFormattingOptions to not do anything by default
---------------------------------------------------------
Key: WINK-202
URL: https://issues.apache.org/jira/browse/WINK-202
Project: Wink
Issue Type: Improvement
Components: Common
Affects Versions: 0.2
Reporter: Bryant Luk
Assignee: Bryant Luk
Fix For: 0.2
Changing XmlFormattingOptions to not do anything by default to help improve
minor compatibility and gain a "cheap" performance benefit (up to 2% overall).
While it's a nice feature to have, it may be unexpected for some clients to
leave out the XML declaration. Furthermore, while the indenting is beneficial
for debugging, generally people will not be reading the XML.
The change should be relatively simple I think:
{code}
if (formatingOptions != null) {
JAXBUtils.setXmlFormattingOptions(marshaller, formatingOptions);
} else {
JAXBUtils.setXmlFormattingOptions(marshaller, XmlFormattingOptions
.getDefaultXmlFormattingOptions());
}
{code}
should get rid of the else statement. This would allow the marshaller to do
whatever the "natural" JDK defaults are automatically.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
