[
https://issues.apache.org/jira/browse/WINK-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767835#action_12767835
]
Bryant Luk commented on WINK-174:
---------------------------------
Hi Wendy,
Took a look at this patch this morning. A few comments:
1) I didn't see where the System Properties are being set back on the
DeploymentConfiguration object.
2) I think there's an assumption that all the property keys will be defined by
the time WinkSystemProperties is called (i.e. wink-default.properties contains
all the properties defined). I'm not entirely sure that's the case but that
can be changed. Some of the properties aren't specified but they take their
defaults in the code (i.e. Properties.getProperty(String name, String
defaultValue) is called so if the property didn't exist, it would be
true/false/some value).
> Improve the configuration model to allow pluggable properties loading
> ---------------------------------------------------------------------
>
> Key: WINK-174
> URL: https://issues.apache.org/jira/browse/WINK-174
> Project: Wink
> Issue Type: Improvement
> Components: Common
> Affects Versions: 0.1, 0.2
> Reporter: Bryant Luk
> Attachments: WINK-174.patch
>
>
> While loading properties from the configuration file is good, it would also
> be nice to support global toggles via system JVM properties (or maybe other
> configuration methods) without requiring a re-packaging of Apache Wink.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
