[
https://issues.apache.org/jira/browse/WINK-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852017#action_12852017
]
Bryant Luk commented on WINK-267:
---------------------------------
I think this one is ok. If someone is already calling internal code, then
exposing this to be non-final wouldn't do any more harm than is already done.
One thing is that users could create a servlet class that delegates down
insteads of extends the internal RestServlet class too if they want to override
certain public servlet functionality but of course they'd probably also want to
override some of the other Wink internal methods.
> RestServlet.service(Http*,Http*) is final
> -----------------------------------------
>
> Key: WINK-267
> URL: https://issues.apache.org/jira/browse/WINK-267
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Reporter: Jason Dillon
> Attachments: 0003-Unfinal-service-Http-Http.patch
>
>
> I'd like to sub-class RestServlet and override this method to add some
> logging context via MDC... but I can't due to it being final:
> {code}
> @Override
> protected final void service(HttpServletRequest httpServletRequest,
> HttpServletResponse httpServletResponse)
> throws ServletException,
> IOException {
> getRequestProcessor().handleRequest(httpServletRequest,
> httpServletResponse);
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
