I did a general search and made the changes where I saw this pattern.
If you see any additional ones, then please feel free to submit a
patch.  Thanks.

On Sun, May 30, 2010 at 1:55 AM, Jason Dillon <[email protected]> wrote:
> I've found a few places, that I happened to bump into while debugging, that 
> do stuff like:
>
> <snip>
>        throw new IllegalArgumentException(String
>            .format("Cannot create default factory for class: %s", 
> String.valueOf(clazz)));
> </snip>
>
> This is complexly pointless use of String.valueOf(), as this is exactly what 
> the "%s" token will do.  So its just wasting a method call, inflating the 
> byte-code and cluttering up the source.
>
> --jason

Reply via email to