BTW, if you upgrade to slf4j 1.6.0, then it will default to a nop impl instead 
of complaining, when no other impl is found.

--jason


On May 30, 2010, at 5:58 AM, Bryant Luk wrote:

> I agree with this change so I'll make the fix for the next version.
> For anyone that does not already have a slf4j impl, you will need to
> include a dependency to your actual implementation.
> 
> On Sun, May 30, 2010 at 1:49 AM, Jason Dillon <[email protected]> wrote:
>> Right now, all of the wink components have a compile dependency on 
>> slf4j-jdk14, which isn't quite right.  You should probably mark the slf4j 
>> implementation you are using as scope=test or optional, so that others (like 
>> me) don't have to go and do stuff like this:
>> 
>>        <dependency>
>>            <groupId>org.apache.wink</groupId>
>>            <artifactId>wink-client</artifactId>
>>            <version>1.1-incubating</version>
>>            <scope>test</scope>
>>            <exclusions>
>>                <exclusion>
>>                    <groupId>org.slf4j</groupId>
>>                    <artifactId>slf4j-jdk14</artifactId>
>>                </exclusion>
>>            </exclusions>
>>        </dependency>
>> 
>>        <dependency>
>>            <groupId>org.apache.wink</groupId>
>>            <artifactId>wink-guice-server</artifactId>
>>            <version>1.1-incubating</version>
>>            <exclusions>
>>                <exclusion>
>>                    <groupId>org.slf4j</groupId>
>>                    <artifactId>slf4j-jdk14</artifactId>
>>                </exclusion>
>>            </exclusions>
>>        </dependency>
>> 
>> Wink, being a library, should not be including an implementation of slf4j, 
>> only the api.  Its up to the integrator (developer using wink, or 
>> application server where wink is deployed) to provide the backing 
>> implementation for the slf4j api.
>> 
>> --jason

Reply via email to