I made the changes to the LICENSE headers and changed the maven-license-plugin in the root pom.xml to not exclude pom.xmls. All files listed on the exclusion list (to my knowledge) either a) really do have the LICENSE header but don't have a file extension so the Maven plugin can't do the check (since it can't determine if it's a plain text file comment needed or an XML comment needed), b) are binary files, or c) cannot have the LICENSE header.
I think this solves the LICENSE header issues Kevan ran into. If anyone encounters an error building, please send an e-mail. On Fri, Jun 25, 2010 at 9:50 AM, Bryant Luk <[email protected]> wrote: > I'll fix up some of the warnings as well. Need a few. > > On Fri, Jun 25, 2010 at 8:14 AM, Jesse A Ramos <[email protected]> wrote: >> Thanks, Kevin, for pointing out these issues. I'll look into them today. >> >> -- Jesse >> >> >> >> >> >> From: >> Kevan Miller <[email protected]> >> To: >> [email protected] >> Date: >> 06/24/2010 10:26 PM >> Subject: >> Re: [VOTE] Release Wink 1.1.1 (RC1) >> >> >> >> A couple of problems. >> >> First, wink-itests/wink-itest/wink-itest-contentencode/pom.xml needs an >> apache source license header. There are some number of additional files >> without a license header. They appear to be trivial, machine generated, or >> syntactically problematic to include a license header. >> >> Next, there's something wrong with the checksums. I spot checked several >> files. For example >> https://repository.apache.org/content/repositories/orgapachewink-003/org/apache/wink/apache-wink/1.1.1-incubating/apache-wink-1.1.1-incubating-src.tar.gz >> >> >> The signature looks ok, but all of the checksums were bad (same for >> apache-wink-1.1.1-incubating.zip... >> >> 2e6620ec280aa808915cc1f7c7bb692e126ba72b >> apache-wink-1.1.1-incubating-src.tar.gz.asc >> 949be5a28efc55eab93d3d79de49874b00667415 >> >> 8c09087c954638444245a8127c3dc3fa >> apache-wink-1.1.1-incubating-src.tar.gz.asc >> 590752ae0e311f4230f315f5111b448a >> >> 66100abe60f2dcda9dfc246f38190a3f63d9e5eb >> apache-wink-1.1.1-incubating-src.tar.gz >> 6a2609297db89addf13b1ae8e53830644479766b >> >> 6d224c05dc417b5c0aa47896cfc860fb apache-wink-1.1.1-incubating-src.tar.gz >> d2d27d70eb6e3565e1f6d9ed95b04812 >> >> These problems need to be fixed. Here's my -1 >> >> --kevan >> >> >> On Jun 21, 2010, at 10:39 AM, Jesse A Ramos wrote: >> >>> Hi, >>> >>> I apologize for the delay. Had a few issues to work though. >>> >>> Now that everything is resolved, I'm calling a vote to release Wink >> 1.1.1 >>> (RC1) >>> >>> The Maven staging area is at: >>> https://repository.apache.org/content/repositories/orgapachewink-003/ >>> >>> The distributions are in: >>> >> https://repository.apache.org/content/repositories/orgapachewink-003/org/apache/wink/apache-wink/1.1.1-incubating/ >> >>> >>> >>> This release is tagged at: >>> >> https://svn.apache.org/repos/asf/incubator/wink/tags/wink-1.1.1-incubating/ >> >>> >>> (revision 956599) >>> >>> The vote will be open here for at least 72 hours. >>> >>> Guide to testing staged releases: >>> http://maven.apache.org/guides/development/guide-testing-releases.html >>> >>> [ ] +1 >>> [ ] +0 >>> [ ] -1 >>> >>> -- Jesse Ramos >> >> >> >> >
