serviceability improvement; externalize strings, confirm formatting
-------------------------------------------------------------------
Key: WINK-297
URL: https://issues.apache.org/jira/browse/WINK-297
Project: Wink
Issue Type: Improvement
Components: Client, Common, Server
Affects Versions: 1.1.2
Reporter: Mike Rheinheimer
Assignee: Mike Rheinheimer
Fix For: 1.1.2
We've needed serviceability improvements for a while. Here's the first pass.
I've externalized all strings that should be externalized, marked the rest with
//$NON-NLS-#$ via Eclipse's tool, and here's the cool part: wrote a unittest
to do the following:
1) checks that the strings that should be externalized are externalized (only
debug messages do not need to be externalized)
2) checks that all keys referred to by Messages.getMessage actually exist
3) checks that there are no unused keys in the resource.properties file
4) checks that the number of params matches up with the number of braces {} in
a formatted log string, both externalized and non-externalized
See attached patch. The test is under
org.apache.wink.common.internal.i18n.MessagesTest.
I'll wait to commit this until the 1.1.1 release vote and process is done.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
