[
https://issues.apache.org/jira/browse/WINK-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921475#action_12921475
]
Luciano Resende commented on WINK-319:
--------------------------------------
1) Was there any particular reason why you changed the list generic types like
List<? extends RequestHandler> to just List<RequestHandler>? I modified your
patch slightly back to the original for that since I didn't understand the
reason.
With the current method signature, I can't do:
config.getRequestUserHandlers().add(new MyResponseHandler() );
With the following error:
The method add(capture#3-of ? extends ResponseHandler) in the type
List<capture#3-of ? extends ResponseHandler> is not applicable for the
arguments (ResponseHandler)
I guess Wink code won't complain, because it seems that you guys don't use that
method in the Wink Runtime code.
2) I also didn't see any changes in RequestProcessor besides formatting
changes. Was there something in that?
After a quick review, it seems more like formatting changes only :).
> Simplify addition of Request/Response handlers
> ----------------------------------------------
>
> Key: WINK-319
> URL: https://issues.apache.org/jira/browse/WINK-319
> Project: Wink
> Issue Type: Improvement
> Components: Server
> Affects Versions: 1.1.1
> Reporter: Luciano Resende
> Attachments: WINK-319.patch
>
>
> Currently, embedding Wink requires extending multiple Wink Server classes,
> particularly if you want to add special handlers etc. It seems that some of
> this could be simplified, particularly in the case of adding user specific
> handlers. I was wondering if, instead of having to provide my own
> DeploymentConfiguration that needs to
> override the specific handler initialization method, we could expose the
> actual list of handlers in the Wink DeploymentConfiguration and allow
> embedders to add new handlers to this list in the getDeploymentConfiguration
> in the Servlet ? This might also require some updates on how the handler
> chain is processed, basically delaying the initialization of the handler
> chain or updating the AbstractHandlersChain to process userHandlers and
> Handlers as two separate lists.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
