On Mon, Nov 7, 2016 at 9:19 PM, Jason A. Donenfeld <[email protected]> wrote: > That's some messed up eclass. Check this out: > > From your log: >> make --jobs=8 --load-average=12 HOSTCC=x86_64-pc-linux-gnu-gcc >> CROSS_COMPILE=x86_64-pc-linux-gnu- 'LDFLAGS=-m elf_x86_64' >> KERNELDIR=/usr/src/linux V=1 clean module >> make -C /usr/src/linux >> M=/tmp/portage/net-misc/wireguard-0.0.20161105/work/WireGuard-experimental-0.0.20161105/src >> clean >> make -C /usr/src/linux >> M=/tmp/portage/net-misc/wireguard-0.0.20161105/work/WireGuard-experimental-0.0.20161105/src >> modules > > By default linux-mod.eclass calls make clean and make module, at the > same time, which results in files randomly getting deleted as it > goes... That seems like a pretty bad default: > >> BUILD_TARGETS=${BUILD_TARGETS:-clean module} > Great find, I couldn't spot it.
> I could override this in the ebuild, which I guess I'll do. But I > think I'd prefer for the eclass to be fixed. I'm CCing the Gentoo team > who manages this, for their input. > Perfect! I looked around other ebuilds that use this eclass, may be they get away with setting `BUILD_TARGETS="all"` (not set at all in wireguard), but I also think a sane default is better. Clean should always be finished before other targets. Kalin. _______________________________________________ WireGuard mailing list [email protected] http://lists.zx2c4.com/mailman/listinfo/wireguard
