On Sat, Apr 25, 2020 at 12:23 AM Simon Rozman <[email protected]> wrote: > > Hi Shawn! > > Thank you. This generally looks good. I can't find any official documentation > on the set of functions and macros from wdm.h, but that's nothing new with > Microsoft. > > I have some nitpicks thou. > > 1. As the atomic.h is no longer used; it could be deleted from the repo. > 2. By removing #include "atomic.h", you should add #include <wdm.h>. wintun.c > is now directly using functions and macros declared in wdm.h. > 3. Please add "Signed-of-by: Shawn Hoffman <[email protected]>" line > to your commit message.
He resubmitted with his S-o-b line. See that patch series for the latest.
