* Jason A. Donenfeld > But it doesn't sync Address=, DNS=, or any routing particulars. That > seems like a problem if it's to become a bona fide "reload" subcommand > of wg-quick, since it's not doing what it should be. On the other > hand, adding it to the systemd unit seems far enough away from core > code that we can kind of say, "eh, this sort of works," which might be > good enough. If even _that_ causes problems for users too, we'd have > to talk about removing it from the systemd unit. But hopefully it > stays under the radar and people don't have overly high expectations.
Absolutely, a 'wg syncconf' wrapper is unable to fully implement every conceivable change to the wg-quick config file. That said, 99.9% of my configuration changes are additions/removal of [Peer] sections that 'wg syncconf' do handle perfectly. Being able to add and remove individual VPN users without disrupting the traffic of other unrelated users is a really big win for me. I would imagine this to ability be highly desirable for most other VPN server operators as well – even for those that do not use systemd. I do use systemd, so I am personally fine with what just got merged. I do have to wonder, though, if I committed some sort of faux pas and/or violated some contribution guideline in posting my initial submission, considering that it was consistently ignored for months even though it implemented essentially the same thing as what ended up being merged just now. Anyway. I would, if you are interested in that, be happy update my patch to rename the new wg-quick action «syncconf» instead of «reload», in order to more clearly indicate that this action will only change the parameters that 'wg syncconf' can change. Tore
