Hi,

I validate what Diab said. It's a good start, hoping option 5 will be possible later.

Thank you for changes.

Have a good day.

Le 26/11/2021 à 10:17, [email protected] a écrit :
I assume you've chosen the "reword" route instead of any larger changes, for the better or worse (though as Bruno said, it would be great if 5) is considered somewhere down the line).

Since this route was chosen, I suggest that we also reword the update prompt itself as I feel that is equally responsible for users "freaking out". After all, it is literally telling users to contact their sysadmin instantly for each update. I propose something along the lines of the following patch (though I guess il8n will be a bit of a pain):

```
From 76ea8a81cf327527089bfea8209bf4f2faa1b6cf Mon Sep 17 00:00:00 2001
From: Diab Neiroukh <[email protected]>
Date: Fri, 26 Nov 2021 09:12:15 +0000
Subject: [PATCH] ui: Don't explicitly tell users to contact their sysadmin for
 updates.

The wording used here practically told users to instantly contact their
system administrators for every update. We can reword it to instead to
implicitly suggest that they contact their system administrator if
the update has not been applied for "a relatively long time".

Signed-off-by: Diab Neiroukh <[email protected]>
---
 ui/updatepage.go | 2 +-
 zgotext.go       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ui/updatepage.go b/ui/updatepage.go
index 96fc87f3..76a8dced 100644
--- a/ui/updatepage.go
+++ b/ui/updatepage.go
@@ -65,7 +65,7 @@ func NewUpdatePage() (*UpdatePage, error) {
     button.SetText(l18n.Sprintf("Update Now"))

     if !IsAdmin {
-        button.SetText(l18n.Sprintf("Please ask the system administrator to update.")) +        button.SetText(l18n.Sprintf("There is an update available. The system administrator should update soon."))
         button.SetEnabled(false)
         status.SetText(l18n.Sprintf("Status: Waiting for administrator"))
     }
diff --git a/zgotext.go b/zgotext.go
index efbb9a80..e35974aa 100644
--- a/zgotext.go
+++ b/zgotext.go
@@ -235,7 +235,7 @@ var messageKeyToIndex = map[string]int{
     "Packet with invalid IP version from %v":                               215,
"Peer":  100,
     "Persistent keepalive:":                                                54, -    "Please ask the system administrator to update.":                       275, +    "There is an update available. The system administrator should update soon.":                         275,      "Preshared key:":                                                       51,      "Protocol version must be 1":                                           85,
     "Public key:":  46,

Reply via email to