On Mon, Dec 6, 2021 at 9:54 PM Mathias Krause <[email protected]> wrote: > > Hi Jason, > > Am 06.12.21 um 20:28 schrieb Jason A. Donenfeld: > > On Mon, Dec 6, 2021 at 7:55 PM Jason A. Donenfeld <[email protected]> wrote: > >> Nice detective work! I just loaded this up on the CI, so we'll see if > >> this does work across the board. > > > > Looks like > > https://git.zx2c4.com/wireguard-linux-compat/commit/?id=42c931dbccf9570f10a84e282daf79f385d51623 > > is all green on https://www.wireguard.com/build-status/ in the > > wireguard-linux-compat category. Let me know if that commit looks okay > > to you or if you want to adjust something about it. After that, I'll > > cut a new compat snapshot release. > > ah, you modified the original commit of mine. Yeah, that works too. > However, I'd add the following to the commit log to account for the > output to input operand move: > > """ > Also make 'out' an input-only operand as it is only used as such. This > not only allows gcc to optimize its usage further, but also works around > older gcc versions, apparently failing to handle multiple alternatives > correctly, as in failing to initialize the 'out' operand with its input > value. > """ >
Sure, will do. Jason
