https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15991

            Bug ID: 15991
           Summary: eap.identity field is overloaded if pseuodonum or
                    reauthentication case
           Product: Wireshark
           Version: 3.0.3
          Hardware: x86
                OS: Ubuntu
            Status: UNCONFIRMED
          Severity: Enhancement
          Priority: Low
         Component: Dissection engine (libwireshark)
          Assignee: bugzilla-ad...@wireshark.org
          Reporter: 0corr...@gmail.com
  Target Milestone: ---

Created attachment 17279
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=17279&action=edit
Example of overloaded eap.identity field when prefix indicates reauthorization

Build Information:
TShark (Wireshark) 3.0.3 (Git commit 6130b92b0ec6)

Copyright 1998-2019 Gerald Combs <ger...@wireshark.org> and contributors.
License GPLv2+: GNU GPL version 2 or later
<http://www.gnu.org/licenses/old-licenses/gpl-2.0.html>
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with libpcap, without POSIX capabilities, without libnl, with
GLib 2.56.4, with zlib 1.2.11, without SMI, without c-ares, without Lua,
without
GnuTLS, with Gcrypt 1.8.1, without Kerberos, without MaxMind DB resolver,
without nghttp2, without LZ4, without Snappy, without libxml2.

Running on Linux 4.15.0-55-generic, with Intel(R) Core(TM) i7-7820HQ CPU @
2.90GHz (with SSE4.2), with 7953 MB of physical memory, with locale
en_US.UTF-8,
with libpcap version 1.8.1, with Gcrypt 1.8.1, with zlib 1.2.11, binary plugins
supported (0 loaded).

Built using gcc 7.4.0.

--
When the eap.identity.wlan.prefix=='2','3','7' where the prefix indicates a
pseudonym or '4','5','8' where the prefix indicates reauthentication, the value
is added to the eap.identity field resulting in two values separated by a
comma.

Suggest adding two fields eap.identity.pseudo and eap.identity.reauth to hold
these fields instead of overloading the eap.identity field. Change is very
minor.

-----------------current code snippet----------------------
    { &hf_eap_identity, {
      "Identity", "eap.identity",
      FT_STRING, BASE_NONE, NULL, 0x0,
      NULL, HFILL }},

    { &hf_eap_identity_pseudo, {
      "Identity (Pseudonym)", "eap.identity",
      FT_STRING, BASE_NONE, NULL, 0x0,
      NULL, HFILL }},

    { &hf_eap_identity_reauth, {
      "Identity (Reauth)", "eap.identity",
      FT_STRING, BASE_NONE, NULL, 0x0,
      NULL, HFILL }},
-------------------------suggested change--------------------
    { &hf_eap_identity, {
      "Identity", "eap.identity",
      FT_STRING, BASE_NONE, NULL, 0x0,
      NULL, HFILL }},

    { &hf_eap_identity_pseudo, {
      "Identity (Pseudonym)", "eap.identity.pseudo",
      FT_STRING, BASE_NONE, NULL, 0x0,
      NULL, HFILL }},

    { &hf_eap_identity_reauth, {
      "Identity (Reauth)", "eap.identity.reauth",
      FT_STRING, BASE_NONE, NULL, 0x0,
      NULL, HFILL }},

---------------------end-------------------------------------------

-- 
You are receiving this mail because:
You are watching all bug changes.
___________________________________________________________________________
Sent via:    Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
             mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

Reply via email to