David Perry <> changed:

           What    |Removed                     |Added
                 CC|                            |

--- Comment #5 from David Perry <> ---
Created attachment 17692
Partial implementation/UI prototype

I thought this bug might help me learn more about the UI side of Wireshark.
I've learned a lot, but not enough to make a complete fix. Still, here's a
partial patch, in case someone more skilled wants to take it from here.

Clicking the "+" next to the display filter box opens the accordion for adding
a filter button as before, but it now offers the UI to allow a user to add a
color filter instead. (I'll add a screenshot.) The buttons for selecting colors
work, and the button for viewing the coloring rules will add the currently
entered filter spec (if any) to the top of the list for the user to edit.

Where it needs work:
* If you open the coloring rules window from this area, it doesn't update the
packet list with any color changes you make.
* I'd like for it to add a color to the coloring rules without having to open
the coloring dialog, but I can't figure out how to make it do that.
* I have more to learn about Qt and Qt Creator. When I moved the "Comment"
field into the tabbed interface, it lost its auto-stretch ability and I haven't
learned enough to get it back yet.

Some of the UI code I added to ui/qt/filter_expression_frame.cpp was adapted
from ui/qt/coloring_rules_dialog.cpp

If it matters, this was developed/tested on Windows 10.

You are receiving this mail because:
You are watching all bug changes.
Sent via:    Wireshark-bugs mailing list <>

Reply via email to