https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16212

--- Comment #3 from Chuck Craft <bubbas...@gmail.com> ---
Thank you for looking at this. Lots to learn here.
(And my confusion mixing MAC, ether addresses, oui, wireless SAs, ...)

> 3. Organization Code: truncated in Packet Details

I think in this case it is the hard coded (32) print length:

epan/dissectors/packet-llc.c
----------------------------
 { &hf_llc_oui,{ "Organization Code",  "llc.oui", FT_UINT24, BASE_OUI, NULL,
0x0, NULL, HFILL }},

epan/proto.c
-------------
hfinfo_number_value_format_display()
   case BASE_OUI:
         /* Found an address string. */
         g_snprintf(buf, 32, "%02x:%02x:%02x (%s)", p_oui[0], p_oui[1],
p_oui[2], manuf_name);

Should the calls to g_snprintf() use MAXNAMELEN or does that break something
else in the packet details display?

-- 
You are receiving this mail because:
You are watching all bug changes.
___________________________________________________________________________
Sent via:    Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
             mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

Reply via email to