https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16648
--- Comment #3 from Guy Harris <ghar...@sonic.net> ---
(In reply to Gerald Combs from comment #1)
> I'm unable to duplicate this in the current master (52512329c2) on Ubuntu
> 18.04, although it looks like we might want to change
>
> info = wmem_new(wmem_file_scope(), dissection_info);
>
> at line 3989 to wmem_new0.
I've made some changes to the RTPS dissector to catch some cases where it was
assuming something was being set previously:
commit 74d7c3d14f0ad79dbf657d80fcfb68bc16cff717 (HEAD -> master, origin/master,
origin/HEAD)
Author: Guy Harris <ghar...@sonic.net>
Date: Sun Jun 21 16:14:25 2020 -0700
RTPS: set the "we have an entity ID" flag whenever the entity ID is set.
Also, remove a comment leftover from an earlier uncommitted version of
these changes.
Change-Id: I0990a186bc280e11a6d0fda05748f5871fb227f1
Reviewed-on: https://code.wireshark.org/review/37542
Reviewed-by: Guy Harris <ghar...@sonic.net>
commit f97e20a011144a56bf72dd92c49167d17713a909
Author: Guy Harris <ghar...@sonic.net>
Date: Sun Jun 21 12:01:07 2020 -0700
RTPS: don't use incompletely filled in GUIDs.
Add to the GUID type a bitmask that indicates which fields have been
filled in; start it out as 0, and then set bits in it as fields get
filled in.
Do not add a type mapping object to the hash table unless the GUID is
completely filled in, and don't look for a type mapping object in the
hash table with a GUID that hasn't been completely filled in as a key.
Bug: 16642
Change-Id: I31db92238adcb2ec2d70b2650e41b14d99001908
Reviewed-on: https://code.wireshark.org/review/37537
Petri-Dish: Guy Harris <ghar...@sonic.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <ghar...@sonic.net>
commit 2eb87432f71cee0d546a1d2178ad9c531ec656ff
Author: Guy Harris <ghar...@sonic.net>
Date: Sat Jun 20 03:14:43 2020 -0700
RTPS: initialize the fields_visited memer of a new type mapping object.
Bug: 16639
Change-Id: Iac8957b3e2ebd41b636d5853c359954cff796527
Reviewed-on: https://code.wireshark.org/review/37521
Petri-Dish: Guy Harris <ghar...@sonic.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <ghar...@sonic.net>
I was loath to brute-force-initialize structures, as not doing so means that
some deeper bugs, such as bug 16642, pop up and can be directly fixed.
--
You are receiving this mail because:
You are watching all bug changes.___________________________________________________________________________
Sent via: Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
