https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635
--- Comment #12 from Jaap Keuter <jaap.keu...@xs4all.nl> 2011-01-30 19:56:53 CET --- Could you have a look at the Code style, portability section of doc/README.developer. I see (and that's mainly the template file) some show stoppers, like: C++ style comments Taking a pointer to a tvb, cast it to a guint8 pointer, dereference it with array index 0 and use that value. Same thing with uint16's, uint32's. No need to attach all these files and patches, please attach only the files needed for the ASN.1 directory in the repository; any generated files will be generated by the core developer on commit. -- Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. ___________________________________________________________________________ Sent via: Wireshark-bugs mailing list <wireshark-bugs@wireshark.org> Archives: http://www.wireshark.org/lists/wireshark-bugs Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
