https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5675

Gerald Combs <ger...@wireshark.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ger...@wireshark.org

--- Comment #2 from Gerald Combs <ger...@wireshark.org> 2011-02-10 11:51:15 PST 
---
(In reply to comment #1)
> The right way to mark a parameter as unused is to put _U_ after it (it expands
> to the appropriate __attribute__ value on compilers that support it and 
> expands
> to nothing on compilers that don't), not to do a self-assignment.  Just do
> 
>     airpcap_add_key_to_list(GtkListStore *key_list_store, gchar* type, gchar*
> key, gchar* ssid _U_)
> 
> or, so that we get a warning if we end up never using it
> 
>     airpcap_add_key_to_list(GtkListStore *key_list_store, gchar* type, gchar*
> key, gchar* ssid
> #ifndef HAVE_AIRPDCAP
>         _U_
> #endif
>         )
> 
> (also not as nice-looking as one would like, but less of a hack than
> self-assigning).

Done in r35899.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
___________________________________________________________________________
Sent via:    Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives:    http://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
             mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

Reply via email to